MAINT: update pysat standards, testing for SPEC-0, operational env #59
+31
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noting that pysat 3.2.0 will break the code, as documented in #51. We may consider just putting the minimum at pysat 3.2.1 to avoid potential issues in the future. |
aburrell
reviewed
Oct 21, 2024
README.md
Outdated
| @@ -17,7 +17,7 @@ Python 3.7+. | |||
|
|
|||
| | Common modules | Community modules | | |||
| | -------------- | ------------------- | | |||
| | netCDF4 | pysat>=3.0.4,<3.2.0 | | |||
| | netCDF4 | pysat>=3.1.0 | | |||
There was a problem hiding this comment.
Suggested change
| | netCDF4 | pysat>=3.1.0 | | |
| | netCDF4 | pysat>=3.2.1 | |
?
docs/installation.rst
Outdated
Comment on lines
17
to
22
| Python 3.9+ and pysat 3.1.0+. | ||
|
|
||
| ================== ==================== | ||
| Common modules Community modules | ||
| ================== ==================== | ||
| netCDF4 pysat>=3.0.4,<3.2.0 | ||
| netCDF4 pysat>=3.1.0 |
pyproject.toml
Outdated
| @@ -39,7 +39,7 @@ dependencies = [ | |||
| "netCDF4", | |||
| "numpy", | |||
| "pandas", | |||
| "pysat >= 3.0.4, <3.2.0", | |||
| "pysat >= 3.1.0", | |||
requirements.txt
Outdated
| @@ -1,5 +1,5 @@ | |||
| netCDF4 | |||
| numpy | |||
| pandas | |||
| pysat>=3.0.3, <3.2.0 | |||
| pysat>=3.1.0 | |||
|
@jklenzing set minimum to 3.2.1 |
|
pinging @aburrell |
aburrell
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #51, #54
Updates multiple standards, including
Because of internal changes at pysat, the minimum version is set to pysat 3.1.0 (released May 2023, ~18 months ago). Since this will still be an alpha release, full backwards compatibility to pysat 3.0 is not implemented. Tests for pysat<3.1.0 are failing for code that has been deprecated and removed (related to higher-order metadata).
In theory, the requirements.txt and test_requirements.txt can be removed as well (again, duplicate standards) since these are not used in the current tests or supported versions. Keeping them for the time being, will revisit at the next RC. Documented in #60.
Type of change
How Has This Been Tested?
via new GitHub Actions tests.
Checklist:
develop(notmain) branchCHANGELOG.md, summarizing the changes